Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] - Error messages for physics specific API calls without implementation #2187

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 16, 2023

Motivation and Context

Physics API calls made without Bullet installed or active return default values. This can cause confusion for users when the code runs, but returns unexpected values. For example, it should be clear that there are no ray cast hits because physics is not available rather than because the ray did not hit anything.

There could be an argument to make these warnings instead of errors. In either case, the code executes rather than crashing.

How Has This Been Tested

Locally in viewer application. CI test without physics active.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 16, 2023
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclegg3 aclegg3 merged commit 7a3e7ba into main Aug 17, 2023
@aclegg3 aclegg3 deleted the no-physics-error-messages branch August 17, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants