Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE/Bugfix]Modify creation of Articulated Object from URDF file name. #2190

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jturner65
Copy link
Contributor

All AO creation is driven by ArticulatedObjectAttributes now, with the caveat that to be used, any ArticulatedObjectAttributes must reference an existing and legitimate URDF file by relative path name from which to actually build the AO. ArticulatedObjectAttributes can be created using the name of their corresponding URDF file, in which case they will reference -that- URDF, and there is no need to complain if there is no existing ArticulatedObjectAttributes matching that name, since a legal one will be created . This PR removes the erroneous and potentially misleading complaint, and proceeds silently to make a new ArticulatedObjectAttributes referencing the passed URDF file if one does not already exist.

This was peeled off this PR, to minimize topical divergence.

Motivation and Context

How Has This Been Tested

All C++ and python tests pass (it's just a message change)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

All AO creation is driven by ArticulatedObjectAttributes now, with the caveat that to be used, any ArticulatedObjectAttributes must reference an existing and legitimate URDF file by relative path name from which to actually build the AO. ArticulatedObjectAttributes can be created using the name of their corresponding URDF file, in which case they will reference -that- URDF, and there is no need to complain if there is no existing ArticulatedObjectAttributes matching that name, since a legal one will be created .
@jturner65 jturner65 requested a review from aclegg3 August 21, 2023 21:14
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 21, 2023
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jturner65 jturner65 merged commit 61c242f into main Aug 21, 2023
1 check passed
@jturner65 jturner65 deleted the AO_BetterCreationMessages branch August 21, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants