Add option to toggle frustum culling in replay renderer.

[0mdc]

Motivation and Context

This changeset adds a config option to disable culling for replay renderers.

The classic replay renderer currently has an issue related to frustum culling. This allows to work-around the issue for immediate needs.

How Has This Been Tested

Tested locally in Python viewer.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[eundersander]

LGTM but Mikael and John should reach consensus before merging.

[jturner65]

LGTM but Mikael and John should reach consensus before merging.
Yeah, we spoke about it last night. I was just leaving some suggestions at his request :) .

If this works how it is needed, then I'm fine with it. It just seems kind of confusing to me.

If the purpose of this new flag to enable frustum culling (dependent on SimConfig's setting) in replay then I think the naming and structure is fine
If the purpose of the new flag is to disable culling in replay regardless of simConfig setting then I would rename it.
If the purpose is to provide independent Replay control of culling, on or off, then the name is also fine but then SimConfig's setting should be ignored.

[jturner65]

After discussing with Mikael, I see that SimConfig's role in this process with ReplayRenderer is not as relevant as I had initially thought (not relevant at all, in fact :) ), so many of my suggestions are equally irrelevant :)