Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE/Bugfix]properly handle multiple sequential ellipses #2219

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR from yesterday added a path normalization feature to fix ellipses in a path that might span a link, where the backstep would be local to the link destination directory and not the directory holding the link. This PR modifies this to properly handle sequences of ellispses, so long as the provided path sequence has named subdirs corresponding to each ellipsis.

How Has This Been Tested

Locally c++ and python. C++ test has been expanded to test this functionality.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 September 28, 2023 13:05
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 28, 2023
@jturner65 jturner65 requested a review from 0mdc September 28, 2023 14:01
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65 jturner65 merged commit aeabb76 into main Sep 28, 2023
1 check passed
@jturner65 jturner65 deleted the PathNormalization2.0 branch September 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants