Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong instance structures in replay renderer test. #2220

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix wrong instance structures in replay renderer test. #2220

merged 1 commit into from
Sep 28, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Sep 28, 2023

Motivation and Context

This changes test instance data structures that were incorrect, but still worked due to luck.

How Has This Been Tested

Tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested a review from jturner65 September 28, 2023 15:19
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 28, 2023
@0mdc 0mdc merged commit 30f4cc7 into main Sep 28, 2023
1 check passed
@0mdc 0mdc deleted the replay-renderer-test-fix branch September 28, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @jturner65 @facebook-github-bot