Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ArticulatedObject creation_attributes #2259

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Nov 3, 2023

Motivation and Context

Follow-up refactor after adding support for ArticulatedObjectAttributes to expose creation attributes for AOs.

How Has This Been Tested

TODO

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 November 3, 2023 19:38
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 3, 2023
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I posted a suggested change to slack (easier to specify there than here, since it involved a couple other files) but it isn't essential, although it would be nice. Your call.

@aclegg3 aclegg3 requested a review from jturner65 November 6, 2023 16:45
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@aclegg3 aclegg3 merged commit 22a9502 into main Nov 7, 2023
1 check passed
@aclegg3 aclegg3 deleted the ao-creation-attr branch November 7, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants