Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[Part 2 of 2] Semantic region building #2307

Merged
merged 28 commits into from
Jan 31, 2024
Merged

--[Part 2 of 2] Semantic region building #2307

merged 28 commits into from
Jan 31, 2024

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Jan 23, 2024 •
edited
Loading

Motivation and Context

This PR uses the Semantic Attributes introduced in this PR to build the Semantic Scene, including any region annotations, which are used to construct SemanticRegions.

How Has This Been Tested

Current c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 23, 2024
@jturner65 jturner65 requested a review from aclegg3 January 23, 2024 17:44
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch 2 times, most recently from cec66b2 to 7d86961 Compare January 23, 2024 20:30
@jturner65 jturner65 marked this pull request as ready for review January 26, 2024 16:39
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch from b8b3e44 to 7e99fc7 Compare January 26, 2024 16:44
jturner65 and others added 13 commits January 29, 2024 14:11
@jturner65
--add support for non-wildcard relative filenames.
1704ba3 
This enables relative path/filename values set in the default attributes section of the scene dataset config to be resolved to real files on attributes load.
@jturner65
--pass semantic attributes to loadSemanticSceneDescriptor instead of …
ab893d0 
…just filename.
@jturner65
--move all semantic scene creation code to SemanticScene
2c9621a
@jturner65
--add semantic region creation and bindings.
9210c44
@jturner65
--fix mp3d test
635e775
@jturner65
--clang-tidy
906a727
@jturner65
--add regions to the scene's region vector
45185d8
@aclegg3 @jturner65
viewer.py region rendering demo
aa73975
@aclegg3 @jturner65
fix viewer typo introduced by flaker
9238d7e
@jturner65
--make extrusions
dd0a73c
@jturner65
--rename sub-configs to SemanticVolumes
59ff50c 
Will eventually be used for describing non-region semantic constructs.
@jturner65
--add construction of volume edges for debug/visualizations.
53563c5
@jturner65
--add semantic visualization in a more formal manner.
eedb92b
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch from f9db344 to eedb92b Compare January 29, 2024 19:11
aclegg3
aclegg3 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jturner65 jturner65 merged commit f964e51 into main Jan 31, 2024
10 checks passed
@jturner65 jturner65 deleted the SemanticRegionBuilding branch January 31, 2024 22:53
@SgtVincent SgtVincent mentioned this pull request Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @aclegg3 @facebook-github-bot