-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max decimal place option to recorder. #2319
Conversation
src/tests/GfxReplayTest.cpp
Outdated
|
||
// read the playback strings | ||
{ | ||
CORRADE_VERIFY(keyframe3Decimals.find("0.555") != std::string::npos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, there's TestSuite::Compare::StringContains and also TestSuite::Compare::StringNotContains for better failure diagnostics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner! Thank you!
…Compare::StringContains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, including the unit test. I have one request below, otherwise LGTM!
Motivation and Context
This changes the gfx-replay
Recorder
to make the maximum float decimal places configurable.This is an easy way to increase performance of JSON-based systems, as well as making the output text more compact.
Example usage:
Example data (update frames):
How Has This Been Tested
Added a unit test, and tested locally on the HITL tool.
Types of changes
Checklist