Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node object IDs for articulated object links. #2376

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Apr 28, 2024

Motivation and Context

This change sets the OBJECT_ID fields for articulated object nodes.

Notes:

  • For gfx-replay use cases, the articulated object link IDs are important. They are used to match gfx-replay instances with real objects.
  • For semantic rendering cases, we might want to have a separate field for the root object ID.
  • Tests are missing.

How Has This Been Tested

Tested using gfx-replay (habitat-sim -> habitat-lab -> Unity).

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from jturner65 and aclegg3 April 28, 2024 21:14
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 28, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this!

@0mdc 0mdc merged commit 9384080 into main Apr 29, 2024
10 checks passed
@0mdc 0mdc deleted the 0mdc/ao_node_object_ids branch April 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants