--[BUGFIX] - Revert markerset subconfig removals; Don't write empty configs to file #2435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the markerset subconfigs when they were empty caused memory corruption in certain rare cases (python variables retaining possession of a removed variable), so the change introduced in this PR is being reverted;
Instead, a subconfig with no values in its entire subconfig hierarchy (all of its own subconfigs and so on, instead of just in its own primary map) will not be written to JSON.
Motivation and Context
How Has This Been Tested
Locally c++ and python tests. Also verified with python app that fix works.
Types of changes
Checklist