Skip to content

Commit

Permalink
disabled completion tests for plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
omry committed Jan 19, 2021
1 parent 4acbc81 commit e8cd36b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,11 @@ def test_plugins_in_directory(
# Run Hydra tests to verify installed plugins did not break anything
if test_hydra_core:
if not SKIP_CORE_TESTS:
run_pytest(session, "tests")
# exclude test_completion for plugins tests.
# 1. It's tested during normal core tests.
# 2. it's somewhat fragile and tend to timeout in mac.
# 3. it's expensive and it's not worth the cost to run it for plugins as well.
run_pytest(session, "tests", "--ignore=tests/test_completion.py")
else:
session.log("Skipping Hydra core tests")

Expand Down

0 comments on commit e8cd36b

Please sign in to comment.