Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking : Defaults list package rename support removed #1140

Closed
omry opened this issue Nov 14, 2020 · 0 comments
Closed

Breaking : Defaults list package rename support removed #1140

omry opened this issue Nov 14, 2020 · 0 comments
Labels
maintenance Project maintenance
Milestone
Hydra 1.0.5

Comments

@omry
Copy link
Collaborator

omry commented Nov 14, 2020 •
edited
Loading

Hydra 1.0 introduced a rarely used capability to rename packages from overrides.
This feature will be removed in Hydra 1.1 because supporting it with recursive defaults - a much requested feature - is extremely difficult.

As such, is it deprecated as of Hydra 1.0.5 and should no longer be used.
If you are relying on it, please comment on this issue.
@omry omry added this to the 1.1.0 milestone Nov 14, 2020
@omry omry changed the title Breaking : Package rename support removed Breaking : Defaults list package rename support removed Nov 16, 2020
@omry omry added the maintenance Project maintenance label Dec 18, 2020
@omry omry mentioned this issue Dec 18, 2020
Closed
@omry omry modified the milestones: Hydra 1.1.0, Hydra 1.0.5 Dec 18, 2020
@omry omry mentioned this issue Dec 29, 2020
Merged
86 tasks
shagunsodhani added a commit to shagunsodhani/hydra that referenced this issue Jan 4, 2021
@shagunsodhani
Add deperication warning for overriding package via cmd.
485b703 
Support for overriding the package via the command line
is deprecated since Hydra 1.0.5 and will be removed
in Hydra 1.1. For more details, refer
facebookresearch#1140.
@shagunsodhani shagunsodhani mentioned this issue Jan 4, 2021
Merged
shagunsodhani added a commit to shagunsodhani/hydra that referenced this issue Jan 7, 2021
@shagunsodhani
Add deperication warning for overriding package via cmd.
fd66d07 
Support for overriding the package via the command line
is deprecated since Hydra 1.0.5 and will be removed
in Hydra 1.1. For more details, refer
facebookresearch#1140.
shagunsodhani added a commit that referenced this issue Jan 7, 2021
@shagunsodhani
Add depreciation warning in 1.0 for renaming package via cmd. (#1264)
8bea143 
* Add deperication warning for overriding package via cmd.

Support for overriding the package via the command line
is deprecated since Hydra 1.0.5 and will be removed
in Hydra 1.1. For more details, refer
#1140.

* Correctly raise the warning after creating the override class

* Update the tests to work with the depreciation warning

* Fix formatting of the error message

* Fix some broken tests

* Simplify testing logic

* Simplify tests

* Simplify tests

* Add two tests checking for package rename

* Format message using dedent

* Format message using dedent

* Add NEWS Entry
shagunsodhani added a commit to shagunsodhani/hydra that referenced this issue Jan 7, 2021
@shagunsodhani
Drop documentation for renaming package via cmd in 1.0
1c512f3 
Related to facebookresearch#1140 facebookresearch#1264
@shagunsodhani shagunsodhani mentioned this issue Jan 7, 2021
Merged
omry pushed a commit that referenced this issue Jan 7, 2021
@shagunsodhani @omry
Drop documentation for renaming package via cmd in 1.0
035f058 
Related to #1140 #1264
@omry omry closed this as completed Jan 7, 2021
shagunsodhani added a commit to shagunsodhani/hydra that referenced this issue Jan 8, 2021
@shagunsodhani
Drop documentation for renaming package via cmd in 1.0
52e63e9 
Related to facebookresearch#1140 facebookresearch#1264
@shagunsodhani shagunsodhani mentioned this issue Jan 8, 2021
Merged
shagunsodhani added a commit that referenced this issue Jan 8, 2021
@shagunsodhani
Drop documentation for renaming package via cmd in 1.0 (#1284)
4397ad1 
Related to #1140 #1264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Project maintenance
Projects
None yet
Milestone
Hydra 1.0.5
Development

No branches or pull requests
1 participant
@omry