Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error msg when handling OmegaConfBaseException in config_loader #1824

Merged
merged 4 commits into from
Sep 16, 2021
Merged

improve error msg when handling OmegaConfBaseException in config_loader #1824

merged 4 commits into from
Sep 16, 2021

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Sep 15, 2021

Closes #1697

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2021
@Jasha10 Jasha10 requested a review from jieru-hu September 15, 2021 09:01
@omry
Copy link
Collaborator

omry commented Sep 15, 2021

Nice.

Since this is an enhancement, I think it should probably go toward Hydra 1.2.
At this point, the main branch is still Hydra 1.1, so it would make sense to create a release branch for 1.1 and freeze it (before merging this).

@Jasha10 Jasha10 merged commit f147d1b into facebookresearch:main Sep 16, 2021
@Jasha10 Jasha10 deleted the closes1697_2 branch September 16, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for merging from defaults list
3 participants
@Jasha10 @omry @facebook-github-bot