Add Callback for saving pickled job info #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pixelb
reviewed
Mar 15, 2022
| output_dir.mkdir(parents=True, exist_ok=True) | ||
| assert output_dir is not None | ||
| with open(str(output_dir / filename), "wb") as file: | ||
| pickle.dump(obj, file) |
There was a problem hiding this comment.
It's probably better from a compatibility / efficiency standpoint to pick an explicit protocol:
https://docs.python.org/3/library/pickle.html
protocol=4 seems like the most appropriate given our supported python version range
There was a problem hiding this comment.
good point, thanks for the link. reading through the doc it seems like there's some extra benefits in setting it to be the highest, so I update it to that. Let me know what you think :)
Jasha10
reviewed
Mar 15, 2022
pixelb
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an experimental Callback for pickling job info. Having this as a Callback enables users to opt-in this behavior.
The doc updates will come after all of #1805 is completed.