support absolute --config-path (#2368) #2395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Jasha10
reviewed
Sep 29, 2022
tests/test_hydra.py
Outdated
| os.path.abspath("tests/test_apps/app_with_multiple_config_dirs/dir2"), | ||
| ], | ||
| ) | ||
| @mark.parametrize("config_name", ["cfg1", "cfg2", "cfg2"]) |
There was a problem hiding this comment.
Suggested change
| @mark.parametrize("config_name", ["cfg1", "cfg2", "cfg2"]) | |
| @mark.parametrize("config_name", ["cfg1", "cfg2"]) |
No need for the additional "cfg2" here. Since there are two separate mark.parametrize decorators, pytest will test against the product of the iterators, as if running a nested for loop:
for config_path in ["dir1", "dir2", os.abspath(...)]:
for config_name in ["cfg1", "cfg2"]:
... # test code here
Jasha10
approved these changes
Sep 29, 2022
This was actually already supported as
os.path.join("/blah", "/abs/config"), just returns "/abs/config",
but we've made this explicit in code and docs now.
Jasha10
approved these changes
Oct 3, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually already supported as
os.path.join("/blah", "/abs/config"), just returns "/abs/config", but we've made this explicit in code and docs now.