Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add srun_args parameter to submitit launcher #2432

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Add srun_args parameter to submitit launcher #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdb2276
Add srun_args parameter
Queuecumber Oct 22, 2022
8b1ba01
empty commit to trigger ci
Jasha10 Oct 24, 2022
17a09bf
Merge branch 'main' into Queuecumber/main
Jasha10 Oct 26, 2022
7906270
add news fragment
Jasha10 Nov 1, 2022
1c55bc8
update submitit launcher docs
Jasha10 Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/hydra_submitit_launcher/hydra_plugins/hydra_submitit_launcher/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ class SlurmQueueConf(BaseQueueConf):
array_parallelism: int = 256
# A list of commands to run in sbatch befure running srun
setup: Optional[List[str]] = None
# Any additional arguments that should be passed to srun
srun_args: Optional[List[str]] = None


@dataclass
Expand Down
1 change: 1 addition & 0 deletions plugins/hydra_submitit_launcher/news/2429.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support to Hydra's slurm launcher config for submitit's `srun_args` parameter.
1 change: 1 addition & 0 deletions website/docs/plugins/submitit_launcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ max_num_timeout: 0
additional_parameters: {}
array_parallelism: 256
setup: null
srun_args: null
```
</details>
<details><summary>Discover the Local Launcher parameters <b>(Expand)</b></summary>
Expand Down