Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore new deprecation message from setuptools. #2731

Closed
wants to merge 1 commit into from
Closed

Ignore new deprecation message from setuptools. #2731

wants to merge 1 commit into from

Conversation

tjni
Copy link

@tjni tjni commented Jul 30, 2023

In setuptools 67.5.0+, a new DeprecationWarning is emitted whenever pkg_resources is imported, which we need to ignore during tests.

I am creating this patch to use in nixpkgs, as I am updating setuptools there. I'm going to close this PR as I don't want to read or sign a CLA (indeed, I don't remember if I have in the past). Feel free to use it or not use it as you see fit.

In setuptools 67.5.0+, a new DeprecationWarning is emitted whenever
pkg_resources is imported, which we need to ignore during tests.
@facebook-github-bot
Copy link
Contributor

Hi @tjni!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@tjni tjni closed this Jul 30, 2023
@tjni tjni deleted the ignore-setuptools-warning branch July 30, 2023 04:39
michelkok added a commit to michelkok/hydra that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants