Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct missing link import typo in colorlog website page. #2998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmcdermott
Copy link

Motivation

There is an issue on the colorlog website:

image

Have you read the Contributing Guidelines on pull requests?

No

Test Plan

Someone should build the website and ensure this is correct. I just noticed that there was no import for GithubLink in the code whereas other similar pages have one (e.g. https://github.com/facebookresearch/hydra/blob/57690d7c4e8b5e88dad07d67278f613a739e6d13/website/docs/advanced/packaging.md?plain=1#L7C1-L8C1)

Related Issues and PRs

None that I know of, but I didn't really check -- I just noticed the issue and figured I'd send this over really quickly given how small it was. Hopefully this is helpful, and apologies if there was a better way to do this!

@facebook-github-bot
Copy link
Contributor

Hi @mmcdermott!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants