New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable name mismatch #125

Open

ariG23498 opened this issue Oct 10, 2022 · 0 comments

ariG23498 commented Oct 10, 2022

Hey folks,

It turns out that the x_masked in the following line should be x_unmasked according to the paper.

mae/models_mae.py

Line 140 in efb2a80

x_masked = torch.gather(x, dim=1, index=ids_keep.unsqueeze(-1).repeat(1, 1, D))

I have also added a similar fix to the transformers library.

PR: huggingface/transformers#18850

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment