[ViTMAE] Renamed variable name #18850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sequence_masked variable is actually the part of the sequence that is kept unmasked for the encoder. This commit renames the variable.
|
The documentation is not available anymore as the PR was closed or merged. |
|
Tagging @NielsRogge, as he's the vision master 👨🏫 |
|
Just a reminder here! |
|
(Niels it currently off, he'll be back in a few days :) ) |
|
FYI, I took this from the original repository: https://github.com/facebookresearch/mae/blob/efb2a8062c206524e35e47d04501ed4f544c0ae8/models_mae.py#L140 |
|
Do you think an issue in the original repository would be a good approach to move forward? @NielsRogge |
|
Yes indeed, to make the authors confirm! |
|
Thanks for leading the effort. Good work! @sgugger and @NielsRogge thanks for the reviews and actions. |
ajsanjoaquin
pushed a commit
to ajsanjoaquin/transformers
that referenced
this pull request
Oct 12, 2022
The sequence_masked variable is actually the part of the sequence that is kept unmasked for the encoder. This commit renames the variable.
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 18, 2022
The sequence_masked variable is actually the part of the sequence that is kept unmasked for the encoder. This commit renames the variable.
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Oct 21, 2022
The sequence_masked variable is actually the part of the sequence that is kept unmasked for the encoder. This commit renames the variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sequence_maskedvariable is actually the part of the sequence that is kept unmasked for the encoder to consume. This commit renames the variable accordingly.CC: @sayakpaul