Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the NetHack variable renaming and _underscore access recently introduced in NLE==0.9.0 #66

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Fixing the NetHack variable renaming and _underscore access recently introduced in NLE==0.9.0 #66

merged 7 commits into from
Dec 9, 2022

Conversation

samvelyan
Copy link
Contributor

@samvelyan samvelyan commented Dec 8, 2022 •
edited
Loading

Fixing issues associated with NLE==0.9.0 release. This concerns the removal of _underscored vars in nle base class and renaming nle.env to nle.nethack.
Closes #64.

@github-actions github-actions bot added core tests Contributions to our tests. labels Dec 8, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2022
@samvelyan samvelyan changed the title Geremia pompei main Fixing the NetHack variable renaming and _underscore access recently introduced in NLE==0.9.0 Dec 8, 2022
@github-actions github-actions bot added the envs Contributions to MiniHack environments label Dec 8, 2022
@samvelyan samvelyan requested a review from cdmatters December 8, 2022 23:07
@samvelyan samvelyan mentioned this pull request Dec 8, 2022
Closed
@samvelyan samvelyan merged commit 2054e7f into main Dec 9, 2022
@samvelyan samvelyan deleted the GeremiaPompei-main branch December 9, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmatters cdmatters cdmatters approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core envs Contributions to MiniHack environments tests Contributions to our tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Minihack does not work with NLE v0.9.0
4 participants
@samvelyan @cdmatters @facebook-github-bot @GeremiaPompei