Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] pytorch lightning integration - training #734

Closed
wants to merge 1 commit into from
Closed

[feat] pytorch lightning integration - training #734

wants to merge 1 commit into from

Conversation

hackgoofer
Copy link
Contributor

@hackgoofer hackgoofer commented Jan 15, 2021 •
edited
Loading

  • pytorch lighting stub mostly involving training
  • Tests for lightning trainer included
  • MVP 0. Training: Goal - Train a model from scratch and reach similar accuracy as using mmf_trainer
    • Setup the training pipeline: done
    • Training on the right device: done
    • Clip gradients: done
    • Optimizer: done
    • LR scheduler (incl. warmup etc): done
    • testcase: train visual_bert on vqa from scratch fo 10 iterations, compare the value: done
    • tests...

Note, the test is affected by: [Blocking] end_train_batch_step does not return train outputs properly: PR #4369

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 15, 2021
@hackgoofer hackgoofer marked this pull request as ready for review January 20, 2021 06:52
facebook-github-bot
facebook-github-bot reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hackgoofer hackgoofer closed this Jan 23, 2021
@hackgoofer hackgoofer deleted the pl branch January 23, 2021 04:09
@hackgoofer
Copy link
Contributor Author

in favor of this: #748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackgoofer @facebook-github-bot