Run linting as part of gha workflow #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
ankitade
added a commit
that referenced
this pull request
Apr 5, 2022
ghstack-source-id: a0c6c166238e7f581adb1891f2a602ddaeba00f3 Pull Request resolved: #13
langong347
reviewed
Apr 5, 2022
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 6, 2022
ghstack-source-id: 4234ef3f14bf2b53b683cf51d5daa228a549aeaa Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 6, 2022
ghstack-source-id: 7c9b6daf142082d2dfe212956670fb237cab1c15 Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 7, 2022
ghstack-source-id: d5c4c980ec5d54179a34d3064413ab05fa2bd105 Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 7, 2022
ghstack-source-id: 6493c75e0b2d3a99e372d02ef805df24826638db Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 9deadcf49a8ce176ff2f95fc0c63f67988667f1b Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 011288a3374ed8fe9ec91ab69e775a3433e5c927 Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 8c2ce69c1b8c02378ef08f510f2d8c77a61546dc Pull Request resolved: #13
[ghstack-poisoned]
ankitade
added a commit
that referenced
this pull request
Apr 8, 2022
ghstack-source-id: 3f8becb06f509b0a453969195a275be89adccf9b Pull Request resolved: #13
|
@ankitade has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ebsmothers
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Run the precommit hooks on the files changed by the current PR. The action will just fail for now, so user will have to make the changes themselves. Will look into adding annotations of the changes next.
Test plan:
Added an unused import to cnn_lstm and the run failed. https://github.com/facebookresearch/multimodal/runs/5879178261?check_suite_focus=true
Removed it and the action passed
https://github.com/facebookresearch/multimodal/runs/5879701467?check_suite_focus=true
Differential Revision: D35490879