Comment out warnings in env check #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Some folks don't seem to like the additional CVAR in the env names. Removing it. Reviewed By: wesbland, minsii Differential Revision: D51124620
Summary: The warnings in env check recursively call the debug initialization, which again calls the env initialization. This causes a deadlock. Differential Revision: D51127118
|
This pull request was exported from Phabricator. Differential Revision: D51127118 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #35 The warnings in env check recursively call the debug initialization, which again calls the env initialization. This causes a deadlock. Reviewed By: kingchc Differential Revision: D51127118 fbshipit-source-id: 7605d3f58d3207cc36316cf291caff9f79863d4f
minsii
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #35 The warnings in env check recursively call the debug initialization, which again calls the env initialization. This causes a deadlock. Reviewed By: kingchc Differential Revision: D51127118 fbshipit-source-id: 7605d3f58d3207cc36316cf291caff9f79863d4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The warnings in env check recursively call the debug initialization,
which again calls the env initialization. This causes a deadlock.
Differential Revision: D51127118