This repository has been archived by the owner on May 6, 2024. It is now read-only.
Add an xlogfile to the generation of the ttyrecs. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cdmatters
force-pushed
the
eric/xlogfile
branch
from
32e4881 to
e3b9912
Compare
An xlogfile is a logfile that gives details of the episodes that have just passed (https://nethackwiki.com/wiki/Xlogfile). These were previously being generated in the HACKDIR (temporary var dir). By setting the SCOREPREFIX and touching the file, you can can change the path that the file (always ending 'xlogfile') is generated. NB: There is a lock based on fnctl on the logfile. To avoid multiple nles in different trying to write to the same file (with the same savedir) we prepend the process number, like ttyrecs. For writing to same savedir within same process, an id should be added to both ttyrec and xlogfile. This can be done in future (along with relabelling ttyrec to ttyrec2). The log file records all COMPLETED episodes (in the NetHack sense), since it derives from the features used to calculate top ten. In standard usage it should lead to one row per episode, with all ttyrecs from the same process in the same file. You can then find the ttyrec corresponding to each row (start counting at 0th row).
cdmatters
force-pushed
the
eric/xlogfile
branch
from
e3b9912 to
8b5361a
Compare
|
(Was review by heiner internally) |
tscmoo
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An xlogfile is a logfile that gives details of the episodes that have
just passed (https://nethackwiki.com/wiki/Xlogfile). These were
previously being generated in the HACKDIR (temporary var dir). By
setting the SCOREPREFIX and touching the file, you can can change the
path that the file (always ending 'xlogfile') is generated.
NB: There is a lock based on fnctl on the logfile. To avoid multiple
nles in different trying to write to the same file (with the same savedir)
we prepend the process number, like ttyrecs. For writing to same savedir
within same process, an id should be added to both ttyrec and xlogfile.
This can be done in future (along with relabelling ttyrec to ttyrec2).
The log file records all COMPLETED episodes (in the NetHack sense),
since it derives from the features used to calculate top ten. In
standard usage it should lead to one row per episode, with all ttyrecs
from the same process in the same file. You can then find the ttyrec
corresponding to each row (start counting at 0th row).