This repository has been archived by the owner on May 6, 2024. It is now read-only.
Fixup libtmt to ensure that unrecognised terminal commands are ignored, #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
to stop random letters writing to the screen. Libtmt is a VT100 terminal emulator. We have adjusted it to let it accept DEC and IBM graphical sets, however we don't intend to support every terminal. If a control sequence is not recognised (eg `ESC [ 1 ; 2; 1 z` -- a command encountered alot in various ttyrecs) we should abort the processing of the sequence rather than returning allowing the `z` to be printed to the screen.
are often used to trigger use of the DEC graphics set. Cf: `https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters`
cdmatters
force-pushed
the
eric/vt420
branch
2 times, most recently
from
6223afd
to
f7eb93e
Compare
Various commands in libtmt reset the attributes of the charact (`attrs`). This is desirable for color (etc), but not for whether we have DEC graphics or not. This meant if we have coloured DEC rendering, rendering would fail. This change ensures the permanance of the DEC flag in attrs, and updates the test file to include this example.
Test now checks the time between last modification and creation of db. This effectively sets a timer on how long it takes to do `mockdata` pytest fixture.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to stop random letters writing to the screen.
Libtmt is a VT100 terminal emulator. We have adjusted it to let it
accept DEC and IBM graphical sets, however we don't intend to support
every terminal. If a control sequence is not recognised (eg
ESC [ 1 ; 2; 1 z-- a command encountered alot in various ttyrecs) we shouldabort the processing of the sequence rather than returning allowing the
zto be printed to the screen.