This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work!
Here is why I create this PR:
(1) Original script uses
image_size = (images.image_sizes[idx][1], images.image_sizes[idx][0])
to resize bbox, which is incorrect because this size is padded with zeros (padding is done in
def to_image_list(tensors, size_divisible)
).We should use original scaled size to resize the bbox, and in my experiment, this improves the performance a lot.
(2) Also, in the data/README, you say that the format is "x, y, w, h".
However, you use
mode=xyxy
in your implementation (BoxList
has defaultmode='xyxy'
).So, I think you should slightly modify your README.
Thank you, and Vilbert is a very good idea and project!