Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX arm64 support for M2 #858

Open
kevinkirkup opened this issue Sep 14, 2023 · 4 comments
Open

OSX arm64 support for M2 #858

kevinkirkup opened this issue Sep 14, 2023 · 4 comments

Comments

@kevinkirkup
Copy link

🚀 Feature

Python package support for OSX arm64 target Arch

Motivation

I'd like to run this locally on Apple Silicone M1/M2 Macs

Pitch

A majority of new developers will be using Macs for development.
All new Apple Mac/Macbooks are using either M1 or M2 with arm64 architectures.

Alternatives

None.

Additional context

Apple LLVM version doesn't support -fopenmp build option.

clang: error: unsupported option '-fopenmp'
@danthe3rd
Copy link
Contributor

Hi,
Most of the performance improvements in xFormers come from optimized CUDA kernels. Adding support for M1/M2 would require to rewrite most of that from scratch, and that's unfortunately not something we plan on doing (and also requires a slightly different expertise)

@rovo79
Copy link

rovo79 commented Sep 21, 2023

Might be helpful to add a note to the README.md that Apple M1/M2 not supported.

@rovo79 rovo79 mentioned this issue Sep 21, 2023
Closed
@danthe3rd
Copy link
Contributor

Good point - I'll add this to my todo-list

@rovo79 rovo79 mentioned this issue Sep 21, 2023
Closed
10 tasks
@rovo79
Copy link

rovo79 commented Sep 21, 2023

@danthe3rd I made a PR for you... hopefully you don't have to add it to your todo-list :)

@james-relata james-relata mentioned this issue Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about Apple Silicon support rovo79/xformers
3 participants
@kevinkirkup @rovo79 @danthe3rd