Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Apple Silicon support #861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rovo79
Copy link

@rovo79 rovo79 commented Sep 21, 2023

@danthe3rd
Add Supported Platforms section to README
Add a new section called "Supported Platforms" before the Installation to set expectations around supported systems before users attempt installation.

Adding this section aims to reduce issues and questions about lack of Apple Silicon support. It makes the limitations explicit upfront, before users try installing.

What does this PR do?

Fixes #858 .

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Add Supported Platforms section to README
Add a new section called "Supported Platforms" before the Installation to set expectations around supported systems before users attempt installation.

Adding this section aims to reduce issues and questions about lack of Apple Silicon support. It makes the limitations explicit upfront, before users try installing.
@facebook-github-bot
Copy link
Contributor

Hi @rovo79!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

README.md Outdated Show resolved Hide resolved
Perfect!

Co-authored-by: dan_the_3rd <43445237+danthe3rd@users.noreply.github.com>
Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting a PR to fix this! I've added a few comments
Can we move this section after the "Installing xFormers" one?

Copy link
Author

@rovo79 rovo79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX arm64 support for M2
3 participants