-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about Apple Silicon support #861
base: main
Are you sure you want to change the base?
Conversation
Add Supported Platforms section to README Add a new section called "Supported Platforms" before the Installation to set expectations around supported systems before users attempt installation. Adding this section aims to reduce issues and questions about lack of Apple Silicon support. It makes the limitations explicit upfront, before users try installing.
Hi @rovo79! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Perfect! Co-authored-by: dan_the_3rd <43445237+danthe3rd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting a PR to fix this! I've added a few comments
Can we move this section after the "Installing xFormers" one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@danthe3rd
Add Supported Platforms section to README
Add a new section called "Supported Platforms" before the Installation to set expectations around supported systems before users attempt installation.
Adding this section aims to reduce issues and questions about lack of Apple Silicon support. It makes the limitations explicit upfront, before users try installing.
What does this PR do?
Fixes #858 .
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.