Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow PHPUnit 11 #225

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat: allow PHPUnit 11 #225

merged 3 commits into from
Feb 2, 2024

Conversation

Chris53897
Copy link

@Chris53897 Chris53897 commented Feb 2, 2024

@Jean85
Copy link
Member

Jean85 commented Feb 2, 2024

PHPUnit 11 does not support PHP 8.1, but you still have failure there too: https://github.com/facile-it/paraunit/actions/runs/7754078301/job/21146669794?pr=225#step:6:11

I suspect the build is broken on the main branch too.

@Jean85 Jean85 linked an issue Feb 2, 2024 that may be closed by this pull request
@Jean85 Jean85 added this to the 2.3 milestone Feb 2, 2024
@Chris53897
Copy link
Author

Thanks for working on this
#227

@Jean85
Copy link
Member

Jean85 commented Feb 2, 2024

Wow, incredible! After making the base build green with #227, it works flawlessly without any change!

I'll add a changelog entry and release it!

@Jean85 Jean85 merged commit 44f5658 into facile-it:2.x Feb 2, 2024
10 checks passed
@Chris53897 Chris53897 deleted the feature/allow-phpunit-11 branch February 3, 2024 10:53
@Chris53897
Copy link
Author

perfect, thanks

@kubawerlos
Copy link
Contributor

it works flawlessly without any change!

@Jean85 that's because PHPUnit was not allowed after all.

PHPUnit 11 requires phpunit/php-code-coverage:^11.0: https://github.com/sebastianbergmann/phpunit/blob/11.0.0/composer.json#L35

Which is not allowed:
https://github.com/facile-it/paraunit/blob/2.3.0/composer.json#L30

@Jean85
Copy link
Member

Jean85 commented Feb 4, 2024

Aw crap, my fault! I didn't check that 11 was effectively running...

@kubawerlos
Copy link
Contributor

I'm on it: #228

@Jean85
Copy link
Member

Jean85 commented Feb 4, 2024

Watch out, there's #229 too, and I've already posted a comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PHPUnit 11
4 participants