Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Breakdown modules #371

Merged
merged 4 commits into from
Oct 1, 2024
Merged

refactor: Breakdown modules #371

merged 4 commits into from
Oct 1, 2024

Conversation

DaveSkender
Copy link
Member

@DaveSkender DaveSkender commented Oct 1, 2024 •
edited
Loading

Goal: use smaller module parts, e.g. NgIf instead of entire CommonModule

  • break CommonModule by only referencing needed @angular/common/X
  • move HttpClientModule (equivalent) to where ApiService is loaded, needed only
  • fix: ref: to chart.js to smaller needs, if possible

@DaveSkender DaveSkender self-assigned this Oct 1, 2024
@DaveSkender DaveSkender marked this pull request as ready for review October 1, 2024 03:36
@DaveSkender DaveSkender merged commit 24ba725 into main Oct 1, 2024
5 checks passed
@DaveSkender DaveSkender deleted the module-fitting branch October 1, 2024 03:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@DaveSkender DaveSkender

Labels
None yet
Projects
Stock Charts
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DaveSkender