Not recognizing "Probable" files as embedded disk images #35
Labels
enhancement
New feature or request
Comments
fadden
added a commit
that referenced
this issue
Oct 26, 2024
We use a pretty narrow definition, because we don't want to have false-positives. This change adds $F1 to the set of possible ProDOS file types (which was previously just BIN and NON), and accepts files with an unrecognized filename extension if their length is exactly 140kiB. (issue #35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The "Probable" (ProDOS-Bootable) project at github.com/a2-4am/probable stores a 140KB disk image in an 800KB ProDOS volume. It should be opened as a sub-image with a double-click in the GUI or via
--depth=max, but currently isn't.The
HasDiskImageAttribs()function in FileIdentifier.cs is responsible for deciding if something might be a disk image, which it does narrowly, using a combination of file type and filename extension. Even if the extension is unknown, we should still recognize it as a disk if the size is exactly 143360 bytes, as that is very likely a 5.25" disk image. We also want to recognize $F1 is a possible disk image file type (we currently only accept BIN or NON).@a2-4am
The text was updated successfully, but these errors were encountered: