Fady/chains #9
Merged
Fady/chains #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WianStipp
reviewed
Jul 30, 2023
dr_claude/chains/matcher.py
Outdated
Comment on lines
16
to
19
| class Symptom(pydantic.BaseModel): | ||
| symptom: str | ||
| present: bool | ||
| retrievals: Optional[List[str]] = None |
There was a problem hiding this comment.
FYI we already have a "Symptom" class in the codebase
dr_claude/chains/matcher.py
Outdated
Comment on lines
28
to
49
| def __init__( | ||
| self, | ||
| llm: LLM, | ||
| symptom_extract_prompt: PromptTemplate, | ||
| symptom_match_prompt: PromptTemplate, | ||
| vectorstore: HuggingFAISS | ||
| ) -> None: | ||
| self.symptom_extract_chain = LLMChain( | ||
| llm=llm, | ||
| prompt=symptom_extract_prompt, | ||
| ) | ||
| symptom_match_chain = LLMChain( | ||
| llm=llm, | ||
| prompt=symptom_match_prompt, | ||
| ) | ||
| self.stuff_retrievals_match_chain = StuffDocumentsChain( | ||
| llm_chain=symptom_match_chain, | ||
| document_variable_name="retrievals", | ||
| verbose=True, | ||
| callbacks=[], | ||
| ) | ||
| self.retriever = vectorstore.as_retriever() |
There was a problem hiding this comment.
I think this init won't be compatible with the Pydantic superclass
dr_claude/chains/matcher.py
Outdated
Comment on lines
51
to
60
| def _call( | ||
| self, | ||
| inputs: Dict[str, Any], | ||
| run_manager: Optional[CallbackManagerForChainRun] = None, | ||
| ) -> Dict[str, Any]: | ||
| raw_symptom_extract = self.symptom_extract_chain(inputs) | ||
| symptom_list = parse_raw_extract(raw_symptom_extract["text"]) | ||
| for symptom in symptom_list.symptoms: # suboptimal but fine for now | ||
| symptom.retrievals = self.retriever.get_relevant_documents(symptom.symptom) | ||
| return self.run_matching_batch(symptom_list) |
There was a problem hiding this comment.
We should add an _acall too
WianStipp
approved these changes
Jul 30, 2023
dr_claude/chains/matcher.py
Outdated
| texts: List[str], | ||
| ) -> "MatchingChain": | ||
| anthropic = Anthropic( | ||
| temperature=0.1, |
There was a problem hiding this comment.
Any reason for the 0.1?
dr_claude/chains/patient.py
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.