Update service exception bubbling

src/KFlearning.Core/API/FlutterGitClient.cs

@@ -4,7 +4,6 @@
 using System.IO;
 using System.Linq;
 using System.Net.Http;
-using System.Net.Http.Headers;
 using System.Reflection;
 using System.Text;
 using System.Threading.Tasks;
@@ -19,6 +18,8 @@ public interface IFlutterGitClient
 
     public class FlutterGitClient : IFlutterGitClient
     {
+        public const string DefaultFlutterVersion = "1.22.6";
+
         private static readonly HttpClient Client;
 
         static FlutterGitClient()
@@ -32,28 +33,21 @@ static FlutterGitClient()
 
         public async Task<string> GetLatestFlutterVersion()
         {
-            try
-            {
-                var response = await Client.GetAsync("https://api.github.com/repos/flutter/flutter/git/refs/tags");
-                response.EnsureSuccessStatusCode();
+            var response = await Client.GetAsync("https://api.github.com/repos/flutter/flutter/git/refs/tags");
+            response.EnsureSuccessStatusCode();
 
-                var serializer = new JsonSerializer();
-                using (var bodyReader = new StreamReader(await response.Content.ReadAsStreamAsync(), Encoding.UTF8))
-                using (var jsonReader = new JsonTextReader(bodyReader))
+            var serializer = new JsonSerializer();
+            using (var bodyReader = new StreamReader(await response.Content.ReadAsStreamAsync(), Encoding.UTF8))
+            using (var jsonReader = new JsonTextReader(bodyReader))
+            {
+                var tags = serializer.Deserialize<List<FlutterGitTag>>(jsonReader);
+                var latest = tags?.LastOrDefault(x => !x.Ref.Contains("pre"));
+                if (latest == null)
                 {
-                    var tags = serializer.Deserialize<List<FlutterGitTag>>(jsonReader);
-                    var latest = tags?.LastOrDefault(x => !x.Ref.Contains("pre"));
-                    if (latest == null)
-                    {
-                        throw new KFlearningException("Tidak dapat menemukan versi Flutter! Silakan download manual.");
-                    }
-
-                    return GetVersionFromTag(latest.Ref);
+                    throw new KFlearningException("Tidak dapat menemukan versi Flutter! Silakan download manual.");
                 }
-            }
-            catch (Exception)
-            {
-                return "1.22.6";
+
+                return GetVersionFromTag(latest.Ref);
             }
         }
 
@@ -67,7 +61,7 @@ private string GetVersionFromTag(string tag)
             return tag.Split('/').Last();
         }
 
-        public partial class FlutterGitTag
+        public class FlutterGitTag
         {
             [JsonProperty("ref")]
             public string Ref { get; set; }

src/KFlearning.Core/Native/NativeConstants.cs

@@ -2,11 +2,26 @@
 {
     internal static class NativeConstants
     {
-        public const string UacRegistryKey = @"Software\Microsoft\Windows\CurrentVersion\Policies\System";
-        public const string UacRegistryValue = "EnableLUA";
-
         public static uint STANDARD_RIGHTS_READ = 0x00020000;
         public static uint TOKEN_QUERY = 0x0008;
         public static uint TOKEN_READ = STANDARD_RIGHTS_READ | TOKEN_QUERY;
+
+        public const string UacRegistryKey = @"Software\Microsoft\Windows\CurrentVersion\Policies\System";
+        public const string UacRegistryValue = "EnableLUA";
+
+        public const string SystemPoliciesKey = @"Software\Microsoft\Windows\CurrentVersion\Policies\System";
+        public const string ActiveDesktopKey = @"Software\Microsoft\Windows\CurrentVersion\Policies\ActiveDesktop";
+        public const string ExplorerKey = @"Software\Microsoft\Windows\Current Version\Policies\Explorer";
+        public const string StoragePoliciesKey = @"SYSTEM\Current Control Set\Control\StorageDevicePolicies";
+        public const string DesktopKey = @"Control Panel\Desktop";
+
+        public const string NoChangingWallPaper = "NoChangingWallPaper";
+        public const string Wallpaper = "Wallpaper";
+        public const string WallpaperStyle = "WallpaperStyle";
+        public const string NoDispCPL = "NoDispCPL";
+        public const string DisableRegistryTools = "DisableRegistryTools";
+        public const string DisableTaskMgr = "DisableTaskMgr";
+        public const string WriteProtect = "WriteProtect";
+        public const string NoControlPanel = "NoControlPanel";
     }
 }

src/KFlearning.Core/Remoting/KFServer.cs

@@ -23,10 +23,9 @@ public class KFServer : IKFServer
         private const string KFserverProcessName = "kfserver";
 
         private readonly IPathManager _pathManager;
-
+        
         public bool IsRunning => Process.GetProcessesByName(KFserverProcessName).Length > 0;
 
-
         public KFServer(IPathManager pathManager)
         {
             _pathManager = pathManager;
@@ -41,6 +40,7 @@ public void Start(string servePath)
                 CreateNoWindow = true,
                 WindowStyle = ProcessWindowStyle.Hidden
             };
+
             Process.Start(startInfo);
         }
 
@@ -51,7 +51,7 @@ public void Stop()
                 foreach (var process in Process.GetProcessesByName(KFserverProcessName))
                 {
                     process.Kill();
-                    process?.Dispose();
+                    process.Dispose();
                 }
             }
             catch (Exception)
@@ -63,12 +63,16 @@ public void Stop()
         public ServerInfo GetInfo()
         {
             if (!NetworkInterface.GetIsNetworkAvailable())
+            {
                 throw new KFlearningException("Komputer ini tidak terhubung ke jaringan.");
+            }
 
             var hosts = Dns.GetHostEntry(Dns.GetHostName());
             var address = hosts.AddressList.FirstOrDefault(x => x.AddressFamily == AddressFamily.InterNetwork);
             if (address == null)
+            {
                 throw new KFlearningException("Tidak dapat menemukan IP komputer.");
+            }
 
             return new ServerInfo
             {
@@ -92,7 +96,7 @@ protected virtual void Dispose(bool disposing)
 
         public void Dispose()
         {
-            Dispose(disposing: true);
+            Dispose(true);
             GC.SuppressFinalize(this);
         }
 

src/KFlearning.Core/Remoting/RemoteShutdownServer.cs

@@ -72,6 +72,7 @@ private void ReceiveCallback(IAsyncResult ar)
         private void ProcessMessage(string message, IPAddress server)
         {
             if (!message.StartsWith(MessageShutdown)) return;
+
             var cluster = message.Split('|')[1];
             ShutdownRequested?.Invoke(this, new ShutdownRequestedEventArgs { Address = server, Clusster = cluster });
         }

src/KFlearning.Core/Services/PathManager.cs

@@ -2,7 +2,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Reflection;
 
 namespace KFlearning.Core.Services
@@ -33,9 +32,7 @@ private enum PathName
         #region Properies
 
         public bool IsVscodeInstalled => _cachedPaths.ContainsKey(PathName.Vscode);
-
         public bool IsKfMingwInstalled => _cachedPaths.ContainsKey(PathName.KFmingw);
-
         public bool IsFlutterInstalled => _cachedPaths.ContainsKey(PathName.Flutter);
 
         #endregion

src/KFlearning.Core/Services/ProcessManager.cs

@@ -22,33 +22,33 @@ public bool IsProcessElevated()
         {
             if (!IsUacEnabled())
             {
-                WindowsIdentity identity = WindowsIdentity.GetCurrent();
-                WindowsPrincipal principal = new WindowsPrincipal(identity);
-                bool result = principal.IsInRole(WindowsBuiltInRole.Administrator)
-                              || principal.IsInRole(0x200); //Domain Administrator
+                var identity = WindowsIdentity.GetCurrent();
+                var principal = new WindowsPrincipal(identity);
+                var result = principal.IsInRole(WindowsBuiltInRole.Administrator)
+                             || principal.IsInRole(0x200); //Domain Administrator
                 return result;
             }
 
             if (!NativeMethods.OpenProcessToken(Process.GetCurrentProcess().Handle, NativeConstants.TOKEN_READ,
-                out TokenSafeHandle tokenHandle))
+                out var tokenHandle))
             {
                 throw new Win32Exception();
             }
 
             using (tokenHandle)
             {
-                int elevationResultSize = Marshal.SizeOf(Enum.GetUnderlyingType(typeof(TOKEN_ELEVATION_TYPE)));
-                IntPtr elevationTypePtr = Marshal.AllocHGlobal(elevationResultSize);
+                var elevationResultSize = Marshal.SizeOf(Enum.GetUnderlyingType(typeof(TOKEN_ELEVATION_TYPE)));
+                var elevationTypePtr = Marshal.AllocHGlobal(elevationResultSize);
 
                 try
                 {
-                    bool success = NativeMethods.GetTokenInformation(tokenHandle,
+                    var success = NativeMethods.GetTokenInformation(tokenHandle,
                         TOKEN_INFORMATION_CLASS.TokenElevationType, elevationTypePtr, (uint) elevationResultSize,
-                        out uint _);
+                        out _);
                     if (success)
                     {
                         var elevationResult = (TOKEN_ELEVATION_TYPE) Marshal.ReadInt32(elevationTypePtr);
-                        bool isProcessAdmin = elevationResult == TOKEN_ELEVATION_TYPE.TokenElevationTypeFull;
+                        var isProcessAdmin = elevationResult == TOKEN_ELEVATION_TYPE.TokenElevationTypeFull;
                         return isProcessAdmin;
                     }
                     else
@@ -66,7 +66,7 @@ public bool IsProcessElevated()
 
         public bool IsUacEnabled()
         {
-            using (RegistryKey uacKey = Registry.LocalMachine.OpenSubKey(NativeConstants.UacRegistryKey, false))
+            using (var uacKey = Registry.LocalMachine.OpenSubKey(NativeConstants.UacRegistryKey, false))
             {
                 return uacKey != null && uacKey.GetValue(NativeConstants.UacRegistryValue).Equals(1);
             }

src/KFlearning.Core/Services/ProcessWatcher.cs

@@ -17,6 +17,7 @@ public interface IProcessWatcher
     public class ProcessWatcher : IProcessWatcher
     {
         private const double PollingInterval = 5 * 60 * 1000;
+
         private readonly object _lock = new object();
         private readonly Timer _timer;
         private DateTime _lastCheck;
@@ -33,6 +34,7 @@ public ProcessWatcher()
         public void Start()
         {
             if (_timer.Enabled) return;
+
             TotalSeconds = 0;
             _lastCheck = DateTime.Now;
             _timer.Start();
@@ -41,6 +43,7 @@ public void Start()
         public void Stop()
         {
             if (!_timer.Enabled) return;
+
             _timer_Elapsed(null, null);
             _timer.Stop();
         }

src/KFlearning.Core/Services/SystemInfoService.cs

@@ -31,47 +31,40 @@ public class SystemInfoService : ISystemInfoService
 
         public void Query()
         {
-            try
-            {
-                if (_isLoaded) return;
-
-                // build device ID
-                string deviceId = "";
-
-                // OS info
-                var queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_OperatingSystem");
-                OS = queryObj["Caption"].ToString();
-                OSVersion = queryObj["Version"].ToString();
-                Architecture = queryObj["OSArchitecture"].ToString();
-                RAM = Convert.ToDouble(queryObj["TotalVisibleMemorySize"].ToString());
-                deviceId = queryObj["TotalVisibleMemorySize"].ToString();
+            if (_isLoaded) return;
 
-                // CPU info
-                queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_Processor");
-                CPU = queryObj["Name"].ToString();
-                deviceId += queryObj["ProcessorId"].ToString();
+            // build device ID
+            string deviceId = "";
 
-                // Logical disk
-                queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_LogicalDisk");
-                deviceId += queryObj["VolumeSerialNumber"].ToString();
+            // OS info
+            var queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_OperatingSystem");
+            OS = queryObj["Caption"].ToString();
+            OSVersion = queryObj["Version"].ToString();
+            Architecture = queryObj["OSArchitecture"].ToString();
+            RAM = Convert.ToDouble(queryObj["TotalVisibleMemorySize"].ToString());
+            deviceId = queryObj["TotalVisibleMemorySize"].ToString();
 
-                // hash the info
-                using (var hasher = new SHA256CryptoServiceProvider())
-                {
-                    var bytes = Encoding.UTF8.GetBytes(deviceId);
-                    var hashed = hasher.ComputeHash(bytes);
-                    var hex = new StringBuilder(hashed.Length * 2);
+            // CPU info
+            queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_Processor");
+            CPU = queryObj["Name"].ToString();
+            deviceId += queryObj["ProcessorId"].ToString();
 
-                    foreach (byte b in hashed) hex.AppendFormat("{0:x2}", b);
-                    DeviceId = hex.ToString();
-                }
+            // Logical disk
+            queryObj = SearchWmi("root\\CIMV2", "SELECT * FROM Win32_LogicalDisk");
+            deviceId += queryObj["VolumeSerialNumber"].ToString();
 
-                _isLoaded = true;
-            }
-            catch (Exception)
+            // hash the info
+            using (var hasher = new SHA256CryptoServiceProvider())
             {
-                // ignore
+                var bytes = Encoding.UTF8.GetBytes(deviceId);
+                var hashed = hasher.ComputeHash(bytes);
+                var hex = new StringBuilder(hashed.Length * 2);
+
+                foreach (byte b in hashed) hex.AppendFormat("{0:x2}", b);
+                DeviceId = hex.ToString();
             }
+
+            _isLoaded = true;
         }
 
         private ManagementBaseObject SearchWmi(string scope, string query)