Use registry startup and remove scheduled task

fahminlb33 · Jun 27, 2020 · babde19 · babde19
1 parent dcf511b
commit babde19
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/KFmaintenance.Setup/KFmaintenance.Setup.wixproj b/src/KFmaintenance.Setup/KFmaintenance.Setup.wixproj
@@ -22,6 +22,7 @@
     <Compile Include="Directory.wxs" />
     <Compile Include="Files.wxs" />
     <Compile Include="Product.wxs" />
+    <Compile Include="Registry.wxs" />
     <Compile Include="Shortcuts.wxs" />
   </ItemGroup>
   <ItemGroup>

diff --git a/src/KFmaintenance.Setup/Product.wxs b/src/KFmaintenance.Setup/Product.wxs
@@ -18,6 +18,7 @@
     <Feature Id="ProductFeature" Title="KFmaintenance" Level="1">
       <ComponentGroupRef Id="ProductComponents" />
       <ComponentGroupRef Id="AppShortcuts" />
+      <ComponentGroupRef Id="AppRegistry" />
     </Feature>
 
     <!-- Properties -->
@@ -38,28 +39,14 @@
 
     <!-- Install Sequence -->
     <InstallExecuteSequence>
-      <Custom Action="CreateScheduledTask" After="InstallFiles">NOT Installed</Custom>
       <Custom Action="CreateFirewallExclusion" After="InstallFiles">NOT Installed</Custom>
-
-      <Custom Action="RemoveScheduledTask" After="InstallFiles">Installed</Custom>
       <Custom Action="RemoveFirewallExclusion" After="InstallFiles">Installed</Custom>
     </InstallExecuteSequence>
   </Product>
 
   <Fragment>
     <!-- Launch App -->
     <CustomAction Id="LaunchApplication" BinaryKey="WixCA" DllEntry="WixShellExec" Impersonate="yes" />
-
-    <!-- Scheduled Task -->
-    <SetProperty Id="CreateScheduledTask" Sequence="execute" Before="CreateScheduledTask"
-             Value="&quot;[SystemFolder]SCHTASKS.EXE&quot; /CREATE /TN &quot;KFmaintenance&quot; /TR &quot;[INSTALLFOLDER]\KFmaintenance.exe&quot; /SC ONSTART" />
-    <CustomAction Id="CreateScheduledTask" BinaryKey="WixCA" DllEntry="WixQuietExec"
-                  Execute="deferred" Return="ignore" Impersonate="no"/>
-
-    <SetProperty Id="RemoveScheduledTask" Sequence="execute" Before="RemoveScheduledTask"
-                 Value="&quot;[SystemFolder]SCHTASKS.EXE&quot; /DELETE /TN &quot;KFmaintenance&quot; /F" />
-    <CustomAction Id="RemoveScheduledTask" BinaryKey="WixCA" DllEntry="WixQuietExec"
-                  Execute="deferred" Return="ignore" Impersonate="no"/>
 
     <!-- Firewall Rules -->
     <SetProperty Id="CreateFirewallExclusion" Sequence="execute" Before="CreateFirewallExclusion"

diff --git a/src/KFmaintenance.Setup/Registry.wxs b/src/KFmaintenance.Setup/Registry.wxs
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
+	<Fragment>
+      <ComponentGroup Id="AppRegistry">
+        <Component Id="AppStartup" Guid="{17082248-B0BE-4C16-93BD-44B8C9269D4C}" Directory="INSTALLFOLDER">
+          <RegistryKey Root="HKCU" Key="Software\Microsoft\Windows\CurrentVersion\Run" Action="createAndRemoveOnUninstall">
+            <RegistryValue Type="string" Name="KFmaintenance" Value="&quot;[#KFmaintenance.exe]&quot;" KeyPath="yes"/>
+          </RegistryKey>
+        </Component>
+      </ComponentGroup>
+	</Fragment>
+</Wix>