Use Oto v2 #130
Use Oto v2 #130
Conversation
| mu.Lock() | ||
| mixer.Stream(samples) |
There was a problem hiding this comment.
I see that in the previous version, error's are ignored. Is this intentional?
| player.Close() | ||
| context.Close() |
There was a problem hiding this comment.
So closing the context isn't supported by Oto. I think this is the only breaking change.
There was a problem hiding this comment.
I mentioned it because I don't really understand what happens when the context is or isn't closed. If it wouldn't be problematic with Oto, I don't think it will be with Beep. However, I do not know if the method description of speaker.Close is accurate.
| @@ -5,7 +5,7 @@ go 1.14 | |||
| require ( | |||
| github.com/gdamore/tcell v1.3.0 | |||
| github.com/hajimehoshi/go-mp3 v0.3.0 | |||
| github.com/hajimehoshi/oto v0.7.1 | |||
| github.com/hajimehoshi/oto/v2 v2.4.0-alpha.4 | |||
There was a problem hiding this comment.
The alpha version contains a fix for this locking problem
There was a problem hiding this comment.
alpha.5 was released very recently.
|
Who are the maintainers of this project? |
|
Hi! Is it possible to help with this PR in any way? Does it need more testing? Being stuck with Oto v1.0 is really not ideal. |
|
IMHO, this project should be archived if this PR cannot be merged... |
|
https://pkg.go.dev/github.com/hajimehoshi/oto/v2@v2.4.0 Oto v2.4.0 has been released |
|
How alive is this project? Other more simple yet important fixes such as #154 don’t get merged either. Apparently 883 repositories rely on this library. Isn’t it time to get something done? I can’t maintain this library alone but I’m definitely willing to help if the current maintainers are overwhelmed and are looking for assistance, or if other people step up and fork. Please let me know. |
|
Oto v3 era is starting now. |
Add more tests and benchmarks
Closes #128