Changed BulkheadImpl.releasePermit to ensure that it claims a permit when running a task from the pending queue #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when running a task from the pending queue Before this change, releasePermit would check the queue but not modify the permit field. This could eventually result in permits being equal to maxPermits and would erroneously report the bulkhead as being full This should fix issue failsafe-lib#365
jhalterman
reviewed
Jun 24, 2023
| CheckedRunnable sleep = () -> { | ||
| ignoreExceptions(() ->{ | ||
| System.out.println("Running sleep task " + (index + 1)); | ||
| TimeUnit.SECONDS.sleep(1); |
There was a problem hiding this comment.
Thanks for this! One suggestion: can you tweak the test case so it runs faster? Maybe a 10ms sleep, where the entire test case runs in < 250ms if possible.
…e test run faster
|
Thanks @nicky9door ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, releasePermit would check the queue but not modify the permit field. This could eventually result in permits being equal to maxPermits and would erroneously report the bulkhead as being full
This should fix issue #365