Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5SP,0.5SP] UI: Allow selecting multiple signals to add at the same time #193

Closed
ivan-cukic opened this issue Jul 30, 2024 · 0 comments
Closed

[0.5SP,0.5SP] UI: Allow selecting multiple signals to add at the same time #193

ivan-cukic opened this issue Jul 30, 2024 · 0 comments
Assignees
@vimpostor
Milestone
CALL#5 - Security...

Comments

@ivan-cukic
Copy link
Contributor

ivan-cukic commented Jul 30, 2024 •
edited
Loading

Allow the user to select several signals and then click a button to add them to the flowgraph. (currently, we have one 'add' button per signal in the list)
@ivan-cukic ivan-cukic converted this from a draft issue Jul 30, 2024
@ivan-cukic ivan-cukic changed the title UI: Allow selecting multiple signals to add at the same time [0.5SP] UI: Allow selecting multiple signals to add at the same time Jul 30, 2024
@RalphSteinhagen RalphSteinhagen moved this from 🆕 Ideas (∞) to 🔖 Selected (3) in Digitizer Reimplementation Jul 30, 2024
@RalphSteinhagen RalphSteinhagen mentioned this issue Jul 30, 2024
Merged
vimpostor added a commit that referenced this issue Aug 16, 2024
@vimpostor
Implement signal multi-selection
d67c1e2 
This way they can be added with fewer clicks.
The latest Imgui version is required for this, as multi-selection has
only recently been implemented in imgui:
ocornut/imgui#6518

Fixes #193

While we are at it, this patch also implements clipping of the list with
an ImGuiListClipper.
This is possible, because all rows have the same height in the table.
With this change, scrolling through a large list (100k+ rows) is
significantly smoother.
@vimpostor vimpostor changed the title [0.5SP] UI: Allow selecting multiple signals to add at the same time [0.5SP,0.5SP] UI: Allow selecting multiple signals to add at the same time Aug 16, 2024
vimpostor added a commit that referenced this issue Aug 16, 2024
@vimpostor
Implement signal multi-selection
dd51a14 
This way they can be added with fewer clicks.
The latest Imgui version is required for this, as multi-selection has
only recently been implemented in imgui:
ocornut/imgui#6518

Fixes #193

While we are at it, this patch also implements clipping of the list with
an ImGuiListClipper.
This is possible, because all rows have the same height in the table.
With this change, scrolling through a large list (100k+ rows) is
significantly smoother.

Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
@vimpostor vimpostor moved this from 🏗 In progress to Finished Implementation (2) in Digitizer Reimplementation Aug 16, 2024
vimpostor added a commit that referenced this issue Aug 16, 2024
@vimpostor
Implement signal multi-selection
a263ce2 
This way they can be added with fewer clicks.
The latest Imgui version is required for this, as multi-selection has
only recently been implemented in imgui:
ocornut/imgui#6518

Fixes #193

While we are at it, this patch also implements clipping of the list with
an ImGuiListClipper.
This is possible, because all rows have the same height in the table.
With this change, scrolling through a large list (100k+ rows) is
significantly smoother.

Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
vimpostor added a commit that referenced this issue Aug 16, 2024
@vimpostor
Implement signal multi-selection
0bfbea2 
This way they can be added with fewer clicks.
The latest Imgui version is required for this, as multi-selection has
only recently been implemented in imgui:
ocornut/imgui#6518

Fixes #193

While we are at it, this patch also implements clipping of the list with
an ImGuiListClipper.
This is possible, because all rows have the same height in the table.
With this change, scrolling through a large list (100k+ rows) is
significantly smoother.

Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
vimpostor added a commit that referenced this issue Sep 2, 2024
@vimpostor
Implement signal multi-selection
0f444a9 
This way they can be added with fewer clicks.
The latest Imgui version is required for this, as multi-selection has
only recently been implemented in imgui:
ocornut/imgui#6518

Fixes #193

While we are at it, this patch also implements clipping of the list with
an ImGuiListClipper.
This is possible, because all rows have the same height in the table.
With this change, scrolling through a large list (100k+ rows) is
significantly smoother.

Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vimpostor vimpostor

Labels
None yet
Projects
Digitizer Reimplementation
Status: ✅ QA-Accepted/Merged (∞)
Milestone
CALL#5 - Security Hardening
Development

No branches or pull requests
3 participants
@ivan-cukic @vimpostor @RalphSteinhagen