fix: node 18 error #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thanks for your findings @IgorShadurin !
Please give it a try with upgrading the bee-js version to 5.1.0 and if it still does not work then let this issue known in some form for the Bee API team.
|
|
Shadowfiend
added a commit
to thesis/valkyrie
that referenced
this pull request
Apr 10, 2023
Seen in fairDataSociety/fdp-play#92 as a potential fix for the mysterious SocketError that's killing the Figma integration at startup.
Shadowfiend
added a commit
to thesis/valkyrie
that referenced
this pull request
Apr 10, 2023
Seen in fairDataSociety/fdp-play#92 as a potential fix for the mysterious SocketError that's killing the Figma integration at startup.
Shadowfiend
added a commit
to thesis/valkyrie
that referenced
this pull request
Apr 11, 2023
Seen in fairDataSociety/fdp-play#92 as a potential fix for the mysterious SocketError that's killing the Figma integration at startup.
Merged
|
Release v2.2.0 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurs when requesting from Node 18 to a bee node (1.11.1) using the beeDebug.getNodeAddresses() method.
It looks like the bee node sends a response with a missing header, or the response is processed incorrectly.
Also, the error disappears if you use the '--no-experimental-fetch' flag for Node 18. Because Node 18 introduced its own fetch, it seems that node-fetch uses this built-in fetch and therefore we get different behavior on different versions of the node.
Some information about the bug: nodejs/undici#583
Close #91