Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Codefair v2 #61

Merged
merged 74 commits into from
Aug 29, 2024
Merged

feat: ✨ Codefair v2 #61

merged 74 commits into from
Aug 29, 2024

Conversation

slugb0t
Copy link
Member

@slugb0t slugb0t commented Aug 28, 2024

New additions to Codefair have been added:

  • Full CWL Validation to entire repositories and an updated UI to see the reports. A newer validation tool has been updated to provide user friendly reports. The older version was a typescript validator from the CWL team while the new one is the CWL team's python validator.
  • UI Dashboard has been added for beta testing. The dashboard will provide a central location of the repositories being managed by Codefair and allow users to update their FAIR Compliance items along with rerunning CWL validations and/or entire FAIR compliance check.
  • Mention of the FAIR-BioRS Guidelines have been removed to prevent users from thinking Codefair is solely for biomedical research software.
  • Workflow on the bot has been optimized to allow potential contributors to quickly and better understand the codebase.
  • File restructuring was done on the bot side to follow standards
  • Single instance db was created for the bot to prevent the db being need to be passed as a parameter through most of the bot functions.
  • An action queue was created for users who install Codefair to a large number of repositories in one installation. This will prevent an organization/user account from being spammed with alerts on issues being opened for each repository. The action queue will be require 5 actions on said repository (pushing to main or pull request opened). Thereafter Codefair will begin it's workflow and create a FAIR Compliance Dashboard Issue
  • Logging has been updated on the bot side to use Consola for better tracking of bot errors and runtime details

slugb0t and others added 30 commits July 25, 2024 13:01
* ✨ feat: add support for cwl validation

* 🚧 wip: rework ui for validation_message

* ✨ feat: add support for rerunning validations

* 🐛 fix: update server error mesage key

* 🐛 fix: sanity check for dashboard issue

* 🐛 fix: update description text
…ering, updated CWL github issue template (#42)

* feat: ✨ support for .cwl file checks (#39)

* refactor: ♻️ update on ui and issue dashboard text (#40)

* feat: ✨ support for .cwl file checks

* refactor: update ui text and dashboard message

* feat: ✨ recursive search for all cwl files in repo

* wip: 🚧 handle multiple cwl validations

* feat: ✨ validate multiple cwl files across repo

* feat: ✨ validate cwl files with deployed server

* refactor: ♻️ apply collapsible table for cwl validation report

* feat: ✨ db singleton + issue number added to installation table

* chore: 🔨 code cleanup

* feat: ✨ remove db as parameters throughout codefair bot

* fix: 🐛 patch verify repo name function

* docs: 📝 add JSDoc comments on new functions

* refactor: ♻️ key value for issue number change

* feat: ✨ rerun cwl validations from frontend, on uninstall delete repo from all collections

* feat: ✨ handles for when issue is closed and reopened
* wip: optmizing bot code

* feat: ✨ combined event listeners for bot + cwl template on no cwl files
* 🚧 wip: update dashboard ui

* 🚧 wip: update dashboard ui

* 💄 style: add breadcrumbs to pages

* 🐛 fix: rework license ui on dashboard

* ✏️ fix: update license body text

* 🐛 fix: vhange view to edit on dashboard buttons
* wip: 🚧 create queue for large org installs

* fix: 🐛 cwl private repo template only if cwls exist

* fix: 🐛 gather proper file metadata and iterate through payload for push event

* fix: 🐛 correct valid/total count in cwl template

* bug: :fix: action count increase only if less than 4
* 🚧 wip: add support for mongodb migrations

* 🐛 fix: add support for github org membership verification

* 💄 style: update alert ui

* 🔊 chore: add console logs for migration steps

* ⏪ revert: only run one update for the migration
* feat: ✨ remove deleted cwl files from db

* dev: 📝 better comments

* fix: 🐛 add await to db search, set to false if gatherd cwl is undefind

* refactor: ♻️ convert getcwlFiles fn to a promise

* refactor: ♻️ remove token from url string in priv repos, update emojis on validation report

* refator: ♻️ sourcery notes

* refactor: ♻️ sourcery notes (push fn out function block
* 🐛 fix: check github org permissions

* 🔒️ fix: remove public config variable

* 🔇 chore: remove logs
* wip: 🚧 action queue handling

* refactor: ♻️ remove close issue feat when app is uninstalled
Copy link

Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!

Copy link

sourcery-ai bot commented Aug 28, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@slugb0t slugb0t requested a review from megasanjay August 28, 2024 21:28
@slugb0t slugb0t merged commit 3ac9ee4 into main Aug 29, 2024
1 check passed
Copy link

Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants