-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ rework all pages #615
Conversation
* refactor: ♻️ condense publications to a single component * fix: 🐛 update variable
* refactor: ♻️ update seo component * feat: ✨ add an impact page * chore: 🔨 update type
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
src/components/seo/seo.tsx
Outdated
<title>{meta.title}</title> | ||
<meta content={meta.description} name="description" /> | ||
<meta property="og:url" content={`${meta.url}${router.asPath}`} /> | ||
<link rel="canonical" href={`${meta.url}${router.asPath}`} /> |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
user-provided value
Untrusted URL redirection depends on a
user-provided value
src/components/seo/seo.tsx
Outdated
<title>{meta.title}</title> | ||
<meta content={meta.description} name="description" /> | ||
<meta property="og:url" content={`${meta.url}${router.asPath}`} /> | ||
<link rel="canonical" href={`${meta.url}${router.asPath}`} /> |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
user-provided value
Cross-site scripting vulnerability due to
user-provided value
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @megasanjay - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
- Ensure sensitive data is not included in the publication details. (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 13 blocking issues
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
src/assets/data/publications.json
Outdated
"project": "sodaforsparc", | ||
"url": "https://doi.org/10.1101/2021.02.10.430563", | ||
"title": "SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data", | ||
"subtitle": "", | ||
"citation": "Bandrowski, A., Grethe, J. S., Pilko, A., Gillespie, T., Pine, G., Patel, B., Surles-Zeigler, M., & Martone, M. E. (2021). SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2021.02.10.430563", | ||
"type": "Preprint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "sodaforsparc", | ||
"url": "https://doi.org/10.1101/2021.02.10.430563", | ||
"title": "SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data", | ||
"subtitle": "", | ||
"citation": "Bandrowski, A., Grethe, J. S., Pilko, A., Gillespie, T., Pine, G., Patel, B., Surles-Zeigler, M., & Martone, M. E. (2021). SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2021.02.10.430563", | ||
"type": "Preprint" | ||
}, | ||
{ | ||
"project": "sodaforsparc", | ||
"url": "https://doi.org/10.1096/fasebj.2020.34.s1.02483", | ||
"title": "SPARC: SODA, an interactive software for curating SPARC datasets", | ||
"subtitle": "", | ||
"citation": "Patel, B., Srivastava, H., Aghasafari, P., & Helmer, K. (2020). SPARC: SODA, an interactive software for curating SPARC datasets. The FASEB Journal, 34(S1), 1–1. https://doi.org/10.1096/fasebj.2020.34.s1.02483", | ||
"type": "Abstract" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "fairshare", | ||
"url": "https://doi.org/10.1038/s41597-023-02463-x", | ||
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2023). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Scientific Data, 10(1). https://doi.org/10.1038/s41597-023-02463-x", | ||
"type": "Journal Article" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
"title": "SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data", | ||
"subtitle": "", | ||
"citation": "Bandrowski, A., Grethe, J. S., Pilko, A., Gillespie, T., Pine, G., Patel, B., Surles-Zeigler, M., & Martone, M. E. (2021). SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2021.02.10.430563", | ||
"type": "Preprint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "fairshare", | ||
"url": "https://doi.org/10.1038/s41597-023-02463-x", | ||
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2023). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Scientific Data, 10(1). https://doi.org/10.1038/s41597-023-02463-x", | ||
"type": "Journal Article" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.1101/2022.04.18.488694", | ||
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2022). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2022.04.18.488694", | ||
"type": "Preprint" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.7490/f1000research.1119054.1", | ||
"title": "Making biomedical research software FAIR with FAIRshare", | ||
"subtitle": "Poster presented at Intelligent Systems for Molecular Biology (ISMB) 2022 and Bioinformatics Open Source Conference (BOSC) 2022", | ||
"citation": "Bhavesh Patel, & Soundarajan, S. (2022). Making biomedical research software FAIR with FAIRshare. F1000 Research Limited. https://doi.org/10.7490/F1000RESEARCH.1119054.1", | ||
"type": "Poster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2023). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Scientific Data, 10(1). https://doi.org/10.1038/s41597-023-02463-x", | ||
"type": "Journal Article" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7363102", | ||
"title": "Software Development Best Practices of the AI-READI Project", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., McWeeney, S., Cordier, B. A., & Benton, E. S. (2022). Software Development Best Practices of the AI-READI Project (v1.0.0). Zenodo. https://doi.org/10.5281/ZENODO.7363102", | ||
"type": "Report" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7363102", | ||
"title": "Software Development Best Practices of the AI-READI Project", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., McWeeney, S., Cordier, B. A., & Benton, E. S. (2022). Software Development Best Practices of the AI-READI Project (v1.0.0). Zenodo. https://doi.org/10.5281/ZENODO.7363102", | ||
"type": "Report" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7363102", | ||
"title": "Software Development Best Practices of the AI-READI Project", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., McWeeney, S., Cordier, B. A., & Benton, E. S. (2022). Software Development Best Practices of the AI-READI Project (v1.0.0). Zenodo. https://doi.org/10.5281/ZENODO.7363102", | ||
"type": "Report" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
src/assets/data/publications.json
Outdated
"title": "SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data", | ||
"subtitle": "", | ||
"citation": "Bandrowski, A., Grethe, J. S., Pilko, A., Gillespie, T., Pine, G., Patel, B., Surles-Zeigler, M., & Martone, M. E. (2021). SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2021.02.10.430563", | ||
"type": "Preprint" | ||
}, | ||
{ | ||
"project": "sodaforsparc", | ||
"url": "https://doi.org/10.1096/fasebj.2020.34.s1.02483", | ||
"title": "SPARC: SODA, an interactive software for curating SPARC datasets", | ||
"subtitle": "", | ||
"citation": "Patel, B., Srivastava, H., Aghasafari, P., & Helmer, K. (2020). SPARC: SODA, an interactive software for curating SPARC datasets. The FASEB Journal, 34(S1), 1–1. https://doi.org/10.1096/fasebj.2020.34.s1.02483", | ||
"type": "Abstract" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.1038/s41597-023-02463-x", | ||
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2023). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Scientific Data, 10(1). https://doi.org/10.1038/s41597-023-02463-x", | ||
"type": "Journal Article" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.1101/2022.04.18.488694", | ||
"title": "Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., Ménager, H., & Hu, Z. (2022). Making Biomedical Research Software FAIR: Actionable Step-by-step Guidelines with a User-support Tool. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2022.04.18.488694", | ||
"type": "Preprint" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.7490/f1000research.1119054.1", | ||
"title": "Making biomedical research software FAIR with FAIRshare", | ||
"subtitle": "Poster presented at Intelligent Systems for Molecular Biology (ISMB) 2022 and Bioinformatics Open Source Conference (BOSC) 2022", | ||
"citation": "Bhavesh Patel, & Soundarajan, S. (2022). Making biomedical research software FAIR with FAIRshare. F1000 Research Limited. https://doi.org/10.7490/F1000RESEARCH.1119054.1", | ||
"type": "Poster" | ||
}, | ||
{ | ||
"project": "fairshare", | ||
"url": "https://doi.org/10.7490/f1000research.1119055.1", | ||
"title": "Making biomedical research software findable, accessible, interoperable, reusable (FAIR) with FAIRshare", | ||
"subtitle": "Slides presented at Intelligent Systems for Molecular Biology (ISMB) 2022 and Bioinformatics Open Source Conference (BOSC) 2022", | ||
"citation": "Bhavesh Patel, & Soundarajan, S. (2022). Making biomedical research software findable, accessible, interoperable, reusable (FAIR) with FAIRshare. F1000 Research Limited. https://doi.org/10.7490/F1000RESEARCH.1119055.1", | ||
"type": "Presentation" | ||
}, | ||
{ | ||
"project": "knowmore", | ||
"url": "https://doi.org/10.1101/2021.08.08.455581", | ||
"title": "KnowMore: An Automated Knowledge Discovery Tool for the FAIR SPARC Datasets", | ||
"subtitle": "", | ||
"citation": "Quey, R., Schiefer, M. A., Kiran, A., & Patel, B. (2021). KnowMore: an automated knowledge discovery tool for the FAIR SPARC datasets. Cold Spring Harbor Laboratory. https://doi.org/10.1101/2021.08.08.455581", | ||
"type": "Preprint" | ||
}, | ||
{ | ||
"project": "aqua", | ||
"url": "https://doi.org/10.12688/f1000research.73018.1", | ||
"title": "AQUA: an Advanced QUery Architecture for the SPARC Portal", | ||
"subtitle": "", | ||
"citation": "Shahidi, N., Lin, X., Munarko, Y., Rasmy, L., & Ngo, T. (2021). AQUA: an Advanced QUery Architecture for the SPARC Portal. F1000Research, 10, 930. https://doi.org/10.12688/f1000research.73018.1", | ||
"type": "Journal Article" | ||
}, | ||
{ | ||
"project": "sparclink", | ||
"url": "https://doi.org/10.12688/f1000research.75071.1", | ||
"title": "SPARClink: an interactive tool to visualize the impact of the SPARC program", | ||
"subtitle": "", | ||
"citation": "Soundarajan, S., Kuruppu, S., Singh, A., Kim, J., & Achalla, M. (2022). SPARClink: an interactive tool to visualize the impact of the SPARC program. F1000Research, 11, 124. https://doi.org/10.12688/f1000research.75071.1", | ||
"type": "Journal Article" | ||
}, | ||
{ | ||
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7363102", | ||
"title": "Software Development Best Practices of the AI-READI Project", | ||
"subtitle": "", | ||
"citation": "Patel, B., Soundarajan, S., McWeeney, S., Cordier, B. A., & Benton, E. S. (2022). Software Development Best Practices of the AI-READI Project (v1.0.0). Zenodo. https://doi.org/10.5281/ZENODO.7363102", | ||
"type": "Report" | ||
}, | ||
{ | ||
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7641650", | ||
"title": "AI-READI Code of Conduct", | ||
"subtitle": "", | ||
"citation": "Lee, A., Owen, J., Patel, B., Nebeker, C., Lee, C., Zangwill, L., Hurst, S., Singer, S., Li-Pook-Than, J., & Matthews, D. (2023). AI-READI Code of Conduct (1.0). Zenodo. https://doi.org/10.5281/ZENODO.7641650", | ||
"type": "Report" | ||
}, | ||
{ | ||
"project": "aireadi", | ||
"url": "https://doi.org/10.5281/zenodo.7641684", | ||
"title": "AI-READI Steering Committee Charter", | ||
"subtitle": "", | ||
"citation": "Lee, A., Owen, J., Patel, B., Nebeker, C., Lee, C., Zangwill, L., Hurst, S., & Singer, S. (2023). AI-READI Steering Committee Charter (1.0). Zenodo. https://doi.org/10.5281/ZENODO.7641684", | ||
"type": "Report" | ||
}, | ||
{ | ||
"project": "sodaforsparc", | ||
"url": "https://sparc.science/news-and-events/community-spotlight/success-stories/sharing-is-caring-making-sparc-data-fair-with-soda", | ||
"title": "Sharing is Caring - Making SPARC data FAIR with SODA", | ||
"subtitle": "", | ||
"citation": "SPARC Data Structure: Rationale and Design of a FAIR Standard for Biomedical Research Data. (2021). SPARC. https://sparc.science/news-and-events/community-spotlight/success-stories/sharing-is-caring-making-sparc-data-fair-with-soda", | ||
"type": "Web Article" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Ensure sensitive data is not included in the publication details.
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://fairdataihub-website-git-home-page-rework-fairdataihub.vercel.app/ |
📝 Changed routes:
And 8 other routes: Commit dc8f673 (https://fairdataihub-website-lp6miggdz-fairdataihub.vercel.app). |
* fix: 🐛 homepage suggestions * feat: ✨ fair-biors project page content --------- Co-authored-by: Bhavesh Patel <b.patel@berkeley.edu>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help! |
🎉 This PR is included in version 2.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.