Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Three Musketeers. needs collinearN and connectPieceTypes. #755

Merged
merged 9 commits into from
Feb 13, 2024
Merged

add Three Musketeers. needs collinearN and connectPieceTypes. #755

merged 9 commits into from
Feb 13, 2024

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented Jan 30, 2024

No description provided.

ianfab
ianfab reviewed Feb 10, 2024
View reviewed changes
Copy link
Member

@ianfab ianfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left a few CR comments. I like the addition of the connectPieceTypes, seems like a fairly natural generalization.

src/position.cpp Outdated Show resolved Hide resolved
src/position.cpp Show resolved Hide resolved
src/variant.h Outdated Show resolved Hide resolved
ianfab
ianfab reviewed Feb 13, 2024
View reviewed changes
src/variant.cpp Outdated Show resolved Hide resolved
@ianfab
Copy link
Member

ianfab commented Feb 13, 2024

Thanks for the updates, looks good to me now. Will merge it after CI has passed.

@ianfab ianfab merged commit 7d42030 into fairy-stockfish:master Feb 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianfab ianfab ianfab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RainRat @ianfab