-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default keybindings F1/F2 to F12/F11. #487
Conversation
i like that! i wish it be merged so soon. |
@lolicon0930 Hey! While we appreciate your contribution, I personally have a few issues with it:
|
@AnErrupTion, hope this is some reasonable explanation:
|
I think a better solution would be to include an option in the configuration to change which function keys to use for shutdown and reboot. What do you think, @lolicon0930? |
@AnErrupTion Ok, no problem. |
Ah, right, I forgot to ask, is |
@lolicon0930 If you mean if it's the default value, then yes it is. |
Then why does the explanation say that ly only accepts values from 0 to 8? |
That's interesting, I never actually noticed this! It does only accept values from 0 to 8, however I have no idea when this little mistake slipped in 😅 |
Start with an initial commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the last change I'm requesting, otherwise it's good to go! Thanks for your contribution!
Include options in the configuration to change which function keys to use for shutdown and reboot. Fix config.map_len size in src/config.c. Add missing defaults in config_defaults() in src/config.c.
Just don't want an unexpected reboot when switching back to tty2.
Maybe you can consider change the default keybind.