Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Xiaomi Mix #725

Closed
wants to merge 2 commits into from
Closed

add Xiaomi Mix #725

wants to merge 2 commits into from

Conversation

toviLau
Copy link

@toviLau toviLau commented May 15, 2024

add Huawei Honor 10 && 10a

Prerequisites

Type of Change

Bug fix, feature, docs update, ...

Description

Please include a summary of the change (current behavior vs new behavior), which issue is fixed (you can also link to an open issue here), and why this change is necessary.

Test

Please describe the tests that you ran to verify your changes.

Impact

Does this PR introduce a breaking change? What changes might users need to make due to this PR?

Other Info

toviLau and others added 2 commits May 15, 2024 16:03
Copy link
Owner

@faisalman faisalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for opening a PR, unfortunately it seems that the newly introduced regex contains something that's considered as unsafe by safe-regex:

1 failing

  1) Test against `safe-regex` : \b;\shry-al00(\T?a)?;\sHMSCore
       should be safe from potentially vulnerable regex:

Maybe try to rearrange the nested quantifiers and make sure npm test doesn't fail.

@faisalman
Copy link
Owner

Please re-open again if the regex issue has been fixed. Thanks!

@faisalman faisalman closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants