fix: datatype.datetime should use static boundaries

faker-js · Jan 29, 2022 · 1a3e2d1 · 1a3e2d1
1 parent a717637
commit 1a3e2d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/datatype.ts b/src/datatype.ts
@@ -109,11 +109,11 @@ export class Datatype {
     options = options || {};
 
     if (typeof options.min === 'undefined' || options.min < minMax * -1) {
-      options.min = new Date().setFullYear(1990, 1, 1);
+      options.min = Date.UTC(1990, 0);
     }
 
     if (typeof options.max === 'undefined' || options.max > minMax) {
-      options.max = new Date().setFullYear(2100, 1, 1);
+      options.max = Date.UTC(2100, 0);
     }
 
     const random = this.faker.datatype.number(options);

diff --git a/test/datatype.spec.ts b/test/datatype.spec.ts
@@ -161,6 +161,12 @@ describe('datatype', () => {
       spy_datatype_number.mockRestore();
     });
 
+    it('should generate a datetime value, checks seeding', () => {
+      faker.seed(100);
+      const generatedDateTime = faker.datatype.datetime();
+      expect(generatedDateTime).toEqual(new Date('2049-10-10T09:07:31.031Z'));
+    });
+
     //generating a datetime with seeding is currently not working
   });