Merge branch 'next' into infra/unicorn/no-array-for-each

faker-js · Oct 10, 2023 · 32b8329 · 32b8329
2 parents 5cdd3ee + 6cb5aa2
commit 32b8329
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -52,7 +52,6 @@ module.exports = defineConfig({
     'unicorn/consistent-destructuring': 'off',
     'unicorn/consistent-function-scoping': 'off',
     'unicorn/escape-case': 'off',
-    'unicorn/explicit-length-check': 'off',
     'unicorn/filename-case': 'off',
     'unicorn/import-style': 'off',
     'unicorn/no-array-callback-reference': 'off',

diff --git a/scripts/apidoc/signature.ts b/scripts/apidoc/signature.ts
@@ -64,7 +64,7 @@ export async function analyzeSignature(
   // Generate usage section
 
   let signatureTypeParametersString = '';
-  if (signatureTypeParameters.length !== 0) {
+  if (signatureTypeParameters.length > 0) {
     signatureTypeParametersString = `<${signatureTypeParameters.join(', ')}>`;
   }
 
@@ -207,7 +207,7 @@ async function typeToText(type_?: Type, short = false): Promise<string> {
         .join(' | ');
 
     case 'reference':
-      if (!type.typeArguments || !type.typeArguments.length) {
+      if (!type.typeArguments || type.typeArguments.length === 0) {
         const reflection = type.reflection as DeclarationReflection | undefined;
         const reflectionType = reflection?.type;
         if (

diff --git a/test/all_functional.spec.ts b/test/all_functional.spec.ts
@@ -70,7 +70,7 @@ function modulesList(): { [module: string]: string[] } {
     .reduce((result, mod) => {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const methods = Object.keys(fakerEN[mod]).filter(isMethodOf(mod));
-      if (methods.length) {
+      if (methods.length > 0) {
         result[mod] = methods;
       } else {
         console.log(`Skipping ${mod} - No testable methods`);

diff --git a/test/vitest-extensions.ts b/test/vitest-extensions.ts
@@ -9,7 +9,7 @@ expect.extend({
     const uniqueDuplication = [...new Set(duplications)];
 
     return {
-      pass: uniqueDuplication.length !== 0,
+      pass: uniqueDuplication.length > 0,
       message: () =>
         isNot
           ? `Duplicated values are [${uniqueDuplication.join(', ')}]`