refactor: reuse types

faker-js · May 31, 2022 · 575351b · 575351b
1 parent b3c3f5f
commit 575351b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 26 deletions.
diff --git a/src/definitions/science.ts b/src/definitions/science.ts
@@ -1,3 +1,4 @@
+import type { ChemicalElement, Unit } from '../modules/science';
 import type { LocaleEntry } from './definitions';
 
 /**
@@ -13,28 +14,3 @@ export type ScienceDefinitions = LocaleEntry<{
    */
   chemicalElement: ChemicalElement[];
 }>;
-
-/**
- * The possible definitions related to elements.
- */
-export interface ChemicalElement {
-  /**
-   * The symbol for the element (e.g. `He`).
-   */
-  symbol: string;
-  /**
-   * The name for the element (e.g. `Cerium`).
-   */
-  name: string;
-}
-
-export interface Unit {
-  /**
-   * The long version of the unit (e.g. `meter`).
-   */
-  name: string;
-  /**
-   * The short version/abbreviation of the element (e.g. `Pa`).
-   */
-  symbol: string;
-}
diff --git a/src/modules/science/index.ts b/src/modules/science/index.ts
@@ -1,12 +1,27 @@
 import type { Faker } from '../..';
 
+/**
+ * The possible definitions related to elements.
+ */
 export interface ChemicalElement {
-  name: string;
+  /**
+   * The symbol for the element (e.g. `He`).
+   */
   symbol: string;
+  /**
+   * The name for the element (e.g. `Cerium`).
+   */
+  name: string;
 }
 
 export interface Unit {
+  /**
+   * The long version of the unit (e.g. `meter`).
+   */
   name: string;
+  /**
+   * The short version/abbreviation of the element (e.g. `Pa`).
+   */
   symbol: string;
 }