update test

faker-js · Mar 7, 2023 · a63eebd · a63eebd
1 parent 295eb65
commit a63eebd
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 67 deletions.
diff --git a/src/definitions/color.ts b/src/definitions/color.ts
@@ -13,14 +13,4 @@ export type ColorDefinitions = LocaleEntry<{
    * Color space names.
    */
   space: string[];
-
-  /**
-   * Functions supported by CSS to produce color.
-   */
-  css_function: string[];
-
-  /**
-   * Color space names supported by CSS.
-   */
-  css_space: string[];
 }>;
diff --git a/src/locales/global/color/css_function.ts b/src/locales/global/color/css_function.ts
diff --git a/src/locales/global/color/css_space.ts b/src/locales/global/color/css_space.ts
diff --git a/src/locales/global/color/index.ts b/src/locales/global/color/index.ts
diff --git a/src/locales/global/index.ts b/src/locales/global/index.ts
@@ -3,12 +3,10 @@
  * Run 'pnpm run generate:locales' to update.
  */
 import type { LocaleDefinition } from '../..';
-import color from './color';
 import internet from './internet';
 
 const global: LocaleDefinition = {
   title: 'Global',
-  color,
   internet,
 };
 

diff --git a/src/modules/color/index.ts b/src/modules/color/index.ts
@@ -1,21 +1,35 @@
 import type { Faker } from '../../faker';
 
-export type CSSFunction =
-  | 'color'
-  | 'rgb'
-  | 'rgba'
-  | 'hsl'
-  | 'hsla'
-  | 'hwb'
-  | 'cmyk'
-  | 'lab'
-  | 'lch';
-export type CSSSpace =
-  | 'sRGB'
-  | 'display-p3'
-  | 'rec2020'
-  | 'a98-rgb'
-  | 'prophoto-rgb';
+// TODO christopher 2023-01-27: Convert these CSS_SPACES and CSS_FUNCTIONS to Enums like SexType (https://github.com/faker-js/faker/pull/1748/files#r1072807325)
+
+/**
+ * Color space names supported by CSS.
+ */
+export const CSS_SPACES = [
+  'sRGB',
+  'display-p3',
+  'rec2020',
+  'a98-rgb',
+  'prophoto-rgb',
+] as const;
+
+/**
+ * Functions supported by CSS to produce color.
+ */
+export const CSS_FUNCTIONS = [
+  'rgb',
+  'rgba',
+  'hsl',
+  'hsla',
+  'hwb',
+  'cmyk',
+  'lab',
+  'lch',
+  'color',
+] as const;
+
+export type CSSFunction = (typeof CSS_FUNCTIONS)[number];
+export type CSSSpace = (typeof CSS_SPACES)[number];
 export type StringColorFormat = 'css' | 'binary';
 export type NumberColorFormat = 'decimal';
 export type ColorFormat = StringColorFormat | NumberColorFormat;
@@ -192,9 +206,7 @@ export class ColorModule {
    * @since 7.0.0
    */
   cssSupportedFunction(): string {
-    return this.faker.helpers.arrayElement(
-      this.faker.definitions.color.css_function
-    );
+    return this.faker.helpers.arrayElement(CSS_FUNCTIONS);
   }
 
   /**
@@ -206,9 +218,7 @@ export class ColorModule {
    * @since 7.0.0
    */
   cssSupportedSpace(): string {
-    return this.faker.helpers.arrayElement(
-      this.faker.definitions.color.css_space
-    );
+    return this.faker.helpers.arrayElement(CSS_SPACES);
   }
 
   /**