Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to image generator functions #1783

Closed
ST-DDT opened this issue Jan 26, 2023 · 1 comment · Fixed by #2159
Closed

Add warning to image generator functions #1783

ST-DDT opened this issue Jan 26, 2023 · 1 comment · Fixed by #2159
Assignees
@ejcheng
Labels
c: docs Improvements or additions to documentation

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 26, 2023

maybe could add a warning in the documentation like

"The images are fetched from an external service outside the control of Faker, and could occasionally contain URLs which point to unexpected or offensive images."

Originally posted by @matthewmayer in #1782 (comment)
@ST-DDT ST-DDT mentioned this issue Jan 26, 2023
Merged
@ejcheng ejcheng added the c: docs Improvements or additions to documentation label Jan 28, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented May 7, 2023

Maybe also add a hint that usage limits may apply.

@ST-DDT ST-DDT mentioned this issue May 7, 2023
Closed
10 tasks
@ejcheng ejcheng mentioned this issue May 14, 2023
Merged
@ST-DDT ST-DDT mentioned this issue Sep 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejcheng ejcheng

Labels
c: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(image): add content warnings to image function jsdocs faker-js/faker
2 participants
@ST-DDT @ejcheng