Turn on strictBindCallApply in tsconfig

[ST-DDT]

#651 partially activated strict mode, this flag was omitted at that time and should probably be turned on.

faker/tsconfig.json

Line 12 in c46c539

// "strictBindCallApply": true,

Related issues:

• chore: partially activate strict mode #651
• Turn on strictNullChecks in tsconfig #1834
• Turn on strictPropertyInitialization in tsconfig #1836
• Turn on noImplicitAny in tsconfig #1837
• Turn on noImplicitThis in tsconfig #1838

[Shinigami92]

I tried to set strictBindCallApply: true but I have a problem in line

faker/src/modules/helpers/unique.ts

Line 140 in c46c539

const result: ReturnType<Method> = method.apply(this, args);

But as we want to get rid of this anyway

• Deprecate helpers.unique for removal #1785

I will put no more effort into strictBindCallApply until then

[ST-DDT]

Is it possible to just replace this with undefined?

[Shinigami92]

Is it possible to just replace this with undefined?

Could you explain a bit how you come to this conclusion? I would like to understand what your thought-process is.

[ST-DDT]

Since the value isnt bound to anything useful in the first place (aka this isnt bound to anything specific since it isnt even in the helpers module directly and thus doesnt get bound by the constructor). We could just drop it entirely.
Or am I missing something?

[Shinigami92]

I suggest setting strictBindCallApply locally and try around a bit on your own
That could speed up the process and doesn't require so much writing here

[ST-DDT]

Done: #1842

[ST-DDT]

Blocked by #1842

---

I no longer know how to fix these lines:

this[name] = this[name].bind(this);

For most modules I can simply do:

this[name] = this[name].bind(this, ...[]);

but that doesn't work for the helpers module.

[ST-DDT]

Blocked by #2102.

• infra: reduce tsconfig complexity #2102

[xDivisionByZerox]

I will close this as this has been activated implicitly in #2102.